Why does Dr. Banks in the future seem surprised on hearing that she had called the Chinese General in Arrival (2016)?
There are two ways she can perceive the future:
As an active observer: Her present consciousness is transported to her future body. This doesn't make sense because if this were the case, every time she experiences a vision about her daughter, she would act confused about where she was and maybe even ask the girl who she was. Instead, she acts as if she's known the girl all her life and converses easily with her.
A passive observer: This would make perfect sense in the movie if not for the General scene. She has no control over what her future self says or does. She simply experiences what her future self is. If this is the correct theory, she would act confidently, maybe even smile and ask the Chinese General for his phone number and wife's death words so her past self can dial him. Not be surprised and shocked.
So what is the correct theory? The final result seems like a mash of the two theories.